[CRIU] [PATCH 06/14] crtools: restore pending signals (v4)

Pavel Emelyanov xemul at parallels.com
Mon Mar 25 15:31:01 EDT 2013


>>> @@ -210,8 +241,11 @@ long __export_restore_thread(struct thread_restore_args *args)
>>>  	pr_info("%ld: Restored\n", sys_gettid());
>>>  
>>>  	restore_finish_stage(CR_STATE_RESTORE);
>>> -	restore_finish_stage(CR_STATE_RESTORE_SIGCHLD);
>>>  
>>> +	if (restore_signals(args->siginfo, args->siginfo_nr, 0))
>>> +		goto core_restore_end;
>>
>> Why isn't it in restore_thread_common ?
> 
> The state should be CR_STATE_RESTORE_SIGCHLD, because restore_signals
> blocks all siganls.

OK. Comment this please.

>>
>>> +
>>> +	restore_finish_stage(CR_STATE_RESTORE_SIGCHLD);
>>>  	futex_dec_and_wake(&thread_inprogress);
>>>  
>>>  	new_sp = (long)rt_sigframe + SIGFRAME_OFFSET;
> .
> 




More information about the CRIU mailing list