[CRIU] [PATCH] restore: Use in_vma_area helper in restore_priv_vma_content

Cyrill Gorcunov gorcunov at openvz.org
Mon Mar 25 08:09:48 EDT 2013


On Mon, Mar 25, 2013 at 04:02:28PM +0400, Andrew Vagin wrote:
> > @@ -301,7 +301,7 @@ static int restore_priv_vma_content(pid_t pid)
> >  			unsigned char buf[PAGE_SIZE];
> >  			void *p;
> >  
> > -			while (va >= vma->vma.end) {
> > +			while (!(in_vma_area(vma, va))) {
> 
> This is correct, but I don't like it. The vma list should be sorted, so
> the origin сondition is correct. We need to add a check, that va is in
> vma, right after this loop.

OK, letme check if I manage to come with some better patch.


More information about the CRIU mailing list