[CRIU] [PATCH] net: Don't fail if there is no ip dump data

[Pavel Emelyanov]

On 03/21/2013 02:25 PM, Cyrill Gorcunov wrote:
> On Thu, Mar 21, 2013 at 02:18:04PM +0400, Pavel Emelyanov wrote:
>> On 03/21/2013 02:03 PM, Cyrill Gorcunov wrote:
>>> On Thu, Mar 21, 2013 at 01:37:30PM +0400, Pavel Emelyanov wrote:
>>>> On 03/21/2013 10:11 AM, Cyrill Gorcunov wrote:
>>>>> If we met empy file just continue execution.
>>>>
>>>> Why is that correct?
>>>
>>> If there is no say route information (everything net related
>>> is down, including lo) i presume the ip dump will be empty,
>>
>> Do you presume, or have checked this?
> 
> While working on cpt2 I've not yet addressed a problem of conversion
> of net related data, thus I wrote "stub" empty files for that and
> found if this situation happens the crtools can't bootstrap because it
> tries to run ip tool with no data provided and fails (while with this
> patch crtools passes and continue trying restore the program).
> 
> Why do we assume that routing/ifaddr/link information will be _always_
> present on any machine?

We don't.
But "routing/ifaddr/link information not present" != "dump file is zero-lenght",
don't you think?

> .
>