[CRIU] [PATCH] zdtm: one more test case for controlling terminals

Andrew Vagin avagin at parallels.com
Tue Mar 19 05:41:21 EDT 2013


Look at the attached patch. With it all tests pass.

On Tue, Mar 19, 2013 at 09:56:21AM +0400, Cyrill Gorcunov wrote:
> On Tue, Mar 19, 2013 at 01:42:56AM +0400, Andrey Vagin wrote:
> >   PID   SID TT       COMMAND
> > 26748 26748 ?        tty03
> > 26749 26749 pts/2     \_ tty03
> > 26750 26750 ?             \_ tty03
> > 
> > The second process has not a file descriptor for the ctl tty,
> > but this tty is opened in tty03.
> > 
> > Currently CRIU can not restore this test case correctly.
> 
> Thanks, I'll take a look.
-------------- next part --------------
diff --git a/tty.c b/tty.c
index 251930b..4e1b6e9 100644
--- a/tty.c
+++ b/tty.c
@@ -731,10 +731,10 @@ static int tty_find_restoring_task(struct tty_info *info)
 	}
 
 	if (info->tie->sid) {
-		if (pty_is_master(info)) {
-			if (tty_has_active_pair(info))
-				return 0;
-		}
+//		if (pty_is_master(info)) {
+//			if (tty_has_active_pair(info))
+//				return 0;
+//		}
 
 		/*
 		 * Find out the task which is session leader


More information about the CRIU mailing list