[CRIU] [PATCH 1/2] ids: Make sure root ids is present in image

Cyrill Gorcunov gorcunov at openvz.org
Fri Mar 15 06:00:19 EDT 2013


On Fri, Mar 15, 2013 at 01:52:08PM +0400, Pavel Emelyanov wrote:
> > read_pstree_image
> > 	...
> > 		ret = pb_read_one(fd, &pi->ids, PB_IDS);
> > 		close(fd);
> > 		if (ret != 1)
> > 			goto err;
> > 
> > so parent->ids can't be nil here.
> 
> So item->ids cannot be NULL as well, why do you think we have
> this check above then?

But ids for root_ids can! Thus instead of nil deref lets be
clever and yield error.


More information about the CRIU mailing list