[CRIU] [PATCH 1/9] parasite: Make parasite arguments variable size

Pavel Emelyanov xemul at parallels.com
Fri Mar 1 13:03:21 EST 2013


On 03/01/2013 09:14 PM, Cyrill Gorcunov wrote:
> On Fri, Mar 01, 2013 at 08:02:20PM +0400, Pavel Emelyanov wrote:
>> diff --git a/pie/pie.lds.S.in b/pie/pie.lds.S.in
>> index 29fef54..7be2eda 100644
>> --- a/pie/pie.lds.S.in
>> +++ b/pie/pie.lds.S.in
>> @@ -21,3 +21,5 @@ SECTIONS
>>  		*(*)
>>  	}
>>  }
>> +
>> +__export_parasite_args = .;
> 
> This (potentially) may generate unaligned address (it won't

I'm not an expert on ld/gcc, but what I've seen so far in various
code is that section ends on x64 were 64-bits aligned. But yet again,
if I'm wrong, then we do need the . = ALIGN(...) line in there. Do we?

> happen on x86-64 but i don't know about arm). Lets leave it
> as is for now, since I've some ideas on how poke parasite
> area in more convenient way and hopefully get rid of such
> linker tricks.
> .
> 




More information about the CRIU mailing list