[CRIU] [PATCH]v1 criu: Initial skeleton for criu library

Kупреев Руслан kupruser at gmail.com
Thu Jul 18 08:25:34 EDT 2013


On 18.07.2013 12:53, Pavel Emelyanov wrote:
> On 07/17/2013 09:51 PM, Kупреев Руслан wrote:
>> Hello all!
>>
>> I make an initial skeleton for CRIU library. It will be used to add
>> different useful functionality.
>>
>>
>> @@ -0,0 +1,12 @@
>> +.PHONY: all clean
>> +
>> +all: libcriu.so
>> +
>> +libcriu.so: criu.o
>> +	$(Q) $(CC) $(CFLAGS) -shared -o $@ criu.o
>> +
>> +criu.o:
>> +	$(Q) $(CC) $(CFLAGS) -fPIC -c criu.c ../include/version.h
> Shouldn't it be "-I../include/"  to ...
>
>> +clean:
>> +	$(Q) $(RM) -f *.o
>> +	$(Q) $(RM) -f *.so
>> diff --git a/lib/criu.c b/lib/criu.c
>> new file mode 100644
>> index 0000000..e613c91
>> --- /dev/null
>> +++ b/lib/criu.c
>> @@ -0,0 +1,3 @@
>> +#include "../include/version.h"
> ... make this look like "#include "version.h" ?
>
>> +/*TMPversion is temporary used to avoid -Werror=unused-variable*/
>> +const char* TMPversion = version;
>
Yes, my mistake.
Fixed.

-------------- next part --------------
commit 387a174746e1fe2a220e0a39cc3a9e45ee9df75a
Author: Ruslan Kupreev <kupruser at gmail.com>
Date:   Thu Jul 18 15:23:06 2013 +0300

    Fixed mistakes of include.

diff --git a/lib/Makefile b/lib/Makefile
index 629962e..0bc4926 100644
--- a/lib/Makefile
+++ b/lib/Makefile
@@ -6,7 +6,7 @@ libcriu.so: criu.o
 	$(Q) $(CC) $(CFLAGS) -shared -o $@ criu.o
 
 criu.o: 
-	$(Q) $(CC) $(CFLAGS) -fPIC -c criu.c ../include/version.h
+	$(Q) $(CC) $(CFLAGS) -fPIC -c criu.c -I ../include/
 clean:
 	$(Q) $(RM) -f *.o
 	$(Q) $(RM) -f *.so
diff --git a/lib/criu.c b/lib/criu.c
index e613c91..1678c66 100644
--- a/lib/criu.c
+++ b/lib/criu.c
@@ -1,3 +1,3 @@
-#include "../include/version.h"
+#include "version.h"
 /*TMPversion is temporary used to avoid -Werror=unused-variable*/
 const char* TMPversion = version;


More information about the CRIU mailing list