[CRIU] [PATCH 1/3] dump: Introduce "post-dump" script action

Cyrill Gorcunov gorcunov at gmail.com
Mon Jul 15 09:07:54 EDT 2013


On Mon, Jul 15, 2013 at 04:58:30PM +0400, Andrew Vagin wrote:
> On Mon, Jul 15, 2013 at 03:49:46PM +0400, Cyrill Gorcunov wrote:
> > On Mon, Jul 15, 2013 at 03:42:28PM +0400, Cyrill Gorcunov wrote:
> > > 
> > > After thinking some more I tend to agree. Letme check if I find some better
> > > code. Thanks!
> > 
> > Something like below? Look, I kept retcode 32 in post-dump.sh since in zdtm
> > we will need to find which code criu exited and somehow distinct it from
> > error cases, no?
> > 
> > 	Cyrill
> 
> Acked-by: Andrew Vagin <avagin at parallels.com>
> 
> Pls, look at one inline comment

Thanks!

> > diff --git a/util.c b/util.c
> > index 69ecf5d..74c14ac 100644
> > --- a/util.c
> > +++ b/util.c
> > @@ -1,3 +1,5 @@
> > +#define _XOPEN_SOURCE
> > +
> 
> ^^^^ a part of another patch

No, it's part of this patch ;) _XOPEN_SOURCE should be defined
in place where system() is invoked, thus we will have it in two
places -- utility.c and cr-dump.c, where we test for WEXITSTATUS.
Of course if only I'm not missing something obvious.


More information about the CRIU mailing list