[CRIU] [PATCH] dump: Introduce "post-dump" script action

Cyrill Gorcunov gorcunov at gmail.com
Fri Jul 12 15:30:55 EDT 2013


On Fri, Jul 12, 2013 at 11:22:59PM +0400, Andrew Vagin wrote:
> On Fri, Jul 12, 2013 at 11:21:16PM +0400, Cyrill Gorcunov wrote:
> > This is usefull if one needs to do some final
> > action before checkpoint is complete. For example
> > in case of online migration one may provide a script
> > which would check that restore procedure on remote
> > note proceeded without errors, thus the script returns
> > zero code and criu simply kills running instance of
> > application. In turn, if migration failed, the script
> > returns nonzero code and criu won't kill the application
> > but continue its execution instead.
> 
> Pls, rework zdtm.sh -d to use this way.

ok

> 
> > 
> > https://bugzilla.openvz.org/show_bug.cgi?id=2583
> > 
> > Signed-off-by: Cyrill Gorcunov <gorcunov at openvz.org>
> > ---
> >  cr-dump.c | 16 ++++++++++++++++
> >  1 file changed, 16 insertions(+)
> > 
> > diff --git a/cr-dump.c b/cr-dump.c
> > index 863bffd..b968f0a 100644
> > --- a/cr-dump.c
> > +++ b/cr-dump.c
> > @@ -1717,6 +1717,22 @@ int cr_dump_tasks(pid_t pid)
> >  err:
> >  	close_cr_fdset(&glob_fdset);
> >
> 
> Why can not we move it upper than "err:"?

To close all global file descriptors, is it bad idea?


More information about the CRIU mailing list