[CRIU] [PATCH] restore: set the zero limit for RLIMIT_CORE

Pavel Emelyanov xemul at parallels.com
Fri Jul 12 10:15:51 EDT 2013


On 07/12/2013 02:31 PM, Cyrill Gorcunov wrote:
> On Fri, Jul 12, 2013 at 01:50:52PM +0400, Andrey Vagin wrote:
>>  
>> +		/* prevent generating core files */
>> +		if (setrlimit(RLIMIT_CORE, &rlim))
>> +			pr_perror("Can't set the zero limit for core files");
> 
> It's slightly unrelated and in general patch looks good for me, I think
> we need some kind of pr_pwarn() which would print warning and errno decoded
> but won't be treated a user as error, since errors should represent real
> errors when progra aborts execution if happened.
> .
> 


Applied.

I agree on having pr_warn() version printing errno. Isn't the %m modifier
designed for that, by the way?


More information about the CRIU mailing list