[CRIU] [PATCH 0/4] ARMv6 support in CRIU

[Sergey Senozhatsky]

On (07/11/13 01:28), Andrew Vagin wrote:
> On Wed, Jul 10, 2013 at 10:15:53AM +0400, Alexander Kartashov wrote:
> > Dear colleagues,
> > 
> > This patchset adds the support for the ARMv6 architecture
> > into CRIU. The primary goal of the patchset is to support
> > the machine Raspberry Pi.
> 
> Alexander, did you forget to sent this:
>

just for note, arm64 defines two possible PAGE_SHIFTs

#ifdef CONFIG_ARM64_64K_PAGES
#define PAGE_SHIFT              16
#else
#define PAGE_SHIFT              12
#endif

thus hardcoded PAGE_SIZE has a troubling potential.

	-ss

> diff --git a/test/zdtm/lib/msg.c b/test/zdtm/lib/msg.c
> index 8a80ae2..33c9806 100644
> --- a/test/zdtm/lib/msg.c
> +++ b/test/zdtm/lib/msg.c
> @@ -11,6 +11,8 @@
>  
>  #include "zdtmtst.h"
>  
> +#define PAGE_SIZE 4096
> +
>  int test_log_init(const char *fname, const char *suffix)
>  {
>         char path[PATH_MAX];
> 
> 
> Compilation fails without this changes:
> 
> cc -g -O2 -Wall -Werror -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0 -iquote
> ./arch/arm/include  -c -o msg.o msg.c
> msg.c: In function ‘test_msg’:
> msg.c:41:11: error: ‘PAGE_SIZE’ undeclared (first use in this function)
> msg.c:41:11: note: each undeclared identifier is reported only once for
> each function it appears in
> msg.c:41:7: error: unused variable ‘buf’ [-Werror=unused-variable]
> 
> > 
> > --
> > Sincerely yours,
> > Alexander Karatshov
> > 
> > _______________________________________________
> > CRIU mailing list
> > CRIU at openvz.org
> > https://lists.openvz.org/mailman/listinfo/criu
> _______________________________________________
> CRIU mailing list
> CRIU at openvz.org
> https://lists.openvz.org/mailman/listinfo/criu