[CRIU] [PATCH 4/5] restore: Add restoration of alternative signal stack

[Pavel Emelyanov]

On 07/10/2013 04:17 PM, Cyrill Gorcunov wrote:
> On Wed, Jul 10, 2013 at 03:55:26PM +0400, Pavel Emelyanov wrote:
>>> diff --git a/pie/restorer.c b/pie/restorer.c
>>> index c4171bd..1407c7c 100644
>>> --- a/pie/restorer.c
>>> +++ b/pie/restorer.c
>>> @@ -773,6 +773,15 @@ long __export_restore_task(struct task_restore_core_args *args)
>>>  		goto core_restore_end;
>>>  
>>>  	/*
>>> +	 * FIXME
>>> +	 * Alternative signal stack for the group leader
>>> +	 * is setting up separately from the threads.
>>> +	 * This better should be unified one day.
>>> +	 */
>>
>> Still don't get it. The construct_sigframe is called for every thread
>> in a group, including the leader one. Why do we need to call this thing
>> again for the group leader?
> 
> Indeed, if only I'm not missing something obvious this could be cleaned up
> some more. What would you prefer -- cleanup on top, or to pass new patch
> here instead?
> .

New patch here instead.