[CRIU] [PATCH 09/10] restore: Add restoration of alternative signal stack

Cyrill Gorcunov gorcunov at gmail.com
Thu Jul 4 04:29:48 EDT 2013


On Thu, Jul 04, 2013 at 03:25:17PM +0400, Pavel Emelyanov wrote:
> >  
> > +	if (core->thread_core->sas) {
> > +		task_args->has_sas = true;
> > +		task_args->sas = *core->thread_core->sas;
> 
> Can we avoid has_sas bool and reuse some sas's field invalid value for that?
> E.g. ss_sp == NULL means no stack looks valid to me.

Sure. I simply wanted to follow has_ manner we already use.

> > +	 *
> > +	 * Second way looks more clean and simple, and here we go.
> > +	 */
> 
> I asked this text in "patch comment", not "code comment". Please :)

LOL. Sure I'll update, gimme some time to pass tests to be sure.


More information about the CRIU mailing list