[CRIU] [PATCH] make: Simplify ARCH retrieval

Alexander Kartashov alekskartashov at parallels.com
Wed Jan 23 10:41:44 EST 2013


On 01/23/2013 07:34 PM, Alexander Kartashov wrote:
> On 01/23/2013 06:50 PM, Cyrill Gorcunov wrote:
>> Actually the former code was being expanding
>> uname_M variable which is not set that early
>> (this was not a problem since we assign it a
>> line below, still it was a dead code which
>> should be fixed).
>>
>> p.s. With this patch the line
>>
>>   | ifeq ($(findstring arm,$(ARCH)),arm)
>>
>> seems to be unneeded and plain
>>
>>   | ifeq ($(ARCH),arm)
>>
>> should work just fine here but I simply
>> have no ARM environment installed at moment
>> so I leave it as is for a while.
>>
>> Reported-by: Andrey Vagin<avagin at openvz.org>
>> Signed-off-by: Cyrill Gorcunov<gorcunov at openvz.org>
>> ---
>>   Makefile | 28 +++++++++++++++++-----------
>>   1 file changed, 17 insertions(+), 11 deletions(-)
>>
>>
>>
>> _______________________________________________
>> CRIU mailing list
>> CRIU at openvz.org
>> https://lists.openvz.org/mailman/listinfo/criu
>
> ack
>
> -- 
> Sincerely yours,
> Alexander Kartashov
>
> Intern
> Core team
>
> www.parallels.com
>
> Skype: aleksandr.kartashov
> Email:alekskartashov at parallels.com
>
>
> _______________________________________________
> CRIU mailing list
> CRIU at openvz.org
> https://lists.openvz.org/mailman/listinfo/criu

You may as well replace the ARM check with

ifeq ($(ARCH),arm)


as you proposed.

-- 
Sincerely yours,
Alexander Kartashov

Intern
Core team

www.parallels.com

Skype: aleksandr.kartashov
Email: alekskartashov at parallels.com

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openvz.org/pipermail/criu/attachments/20130123/1b929d82/attachment.html>


More information about the CRIU mailing list