[CRIU] [PATCH] zdtm: autodetect the target machine

Andrey Vagin avagin at parallels.com
Wed Jan 23 09:36:48 EST 2013


On Wed, Jan 23, 2013 at 05:44:16PM +0400, Pavel Emelyanov wrote:
> On 01/23/2013 04:27 PM, Alexander Kartashov wrote:
> > Andrew Vagin pointed out that the script test/zdtm.sh may be
> > invoked as standalone so the variable ARCH won't be available.
> > 
> > This patch enables test/zdtm.sh to detect the target machine
> > by itself.
> > 
> > Signed-off-by: Alexander Kartashov <alekskartashov at parallels.com>
> 
> Andrey, please review.

NAK

ARCH should be defined in Makefile.

I whould be happy, if make can be executed from test/zdtm/live/static
> 
> > ---
> >  test/zdtm.sh |    9 +++++++++
> >  1 file changed, 9 insertions(+)
> > 
> > diff --git a/test/zdtm.sh b/test/zdtm.sh
> > index 2c91793..2765343 100755
> > --- a/test/zdtm.sh
> > +++ b/test/zdtm.sh
> > @@ -428,6 +428,15 @@ while :; do
> >  	break;
> >  done
> >  
> > +if [ -z $ARCH ]; then
> > +	MACH=`uname -m`
> > +	if [ "$MACH" == x86_64 ]; then
> > +		ARCH=x86
> > +	fi
> > +
> > +	export ARCH
> > +fi
> > +
> >  if [ $# -eq 0 ]; then
> >  
> >  	check_mainstream || exit 1
> > 
> 
> 


More information about the CRIU mailing list