[CRIU] [PATCH 0/2] protobuf: Unweave x86 code out of core.proto

Cyrill Gorcunov gorcunov at openvz.org
Wed Jan 16 17:33:49 EST 2013


Hi guys, since I'm working on feature which is quite alternate with
architecture specific code (in particular CoreEntry allocation, cpu
features retrieval, parasite code as a daemon), and taking into account
that there is very intensive development on ARM port, I decided to take
a look and figure out what exactly might be needed to unweave x86 specific
code from the crtools itself.

I believe this task is very important since otherwise if we don't unweave
the arch-dep snippets now it'll be a way more harder to do in future.

I've been reviewing our code base and here is what I think we might have
as a final result of arch transition

 -  syscall table generation and building should be done under (I'll refer
    to x86 here, but arm port should follow I believe)

        arch/x86/syscall

 -  pie code (ie parasite and restorer) should live in

        arch/x86/pie

    and build there as well. If there is some common parts for code which
    all architectures are sharing -- we might introduce

        arch/common

    directory where those files would locate. For example log-simple.c
    could live exactly there since as far as I can say it should fit
    general-arch-pie code requirement. Thus we will have

        arch/common
            Makefile
            pie/
                Makefile
                log-simple.c
            some-other-files

 -  any other arch specific code (as say cpu.c|h files which I need for
    FPU c/r sake) should live in

        arch/x86/

    directly (at moment there are a couple of files already which I've
    not been reading precisely yet).

What you guys think about that?

Cyrill Gorcunov (2):
  protobuf: Move x86 dependent code to protobuf/arch/x86 directory
  protobuf: x86 -- Use thread-info.proto

 Makefile                            |  5 ++-
 protobuf/Makefile                   | 37 +++++++++++++++++++---
 protobuf/arch/x86/thread-info.proto | 61 ++++++++++++++++++++++++++++++++++++
 protobuf/core.proto                 | 62 +------------------------------------
 4 files changed, 98 insertions(+), 67 deletions(-)
 create mode 100644 protobuf/arch/x86/thread-info.proto

-- 
1.8.0.2


More information about the CRIU mailing list