[CRIU] [PATCH 5/9] print_hex_l: specify the size of the argument explicitly

Pavel Emelyanov xemul at parallels.com
Wed Jan 16 10:33:26 EST 2013


On 01/16/2013 12:28 PM, Alexander Kartashov wrote:
> 
> Signed-off-by: Alexander Kartashov <alekskartashov at parallels.com>
> ---
>  pie/log-simple.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/pie/log-simple.c b/pie/log-simple.c
> index eb940c1..8307c95 100644
> --- a/pie/log-simple.c
> +++ b/pie/log-simple.c
> @@ -123,7 +123,7 @@ static void print_hex(unsigned int num)
>  	sys_write(logfd, z, sizeof(buf) - (z - buf));
>  }
>  
> -static void print_hex_l(unsigned long num)
> +static void print_hex_l(uint64_t num)

This breaks log-simple's formats compatibility.

>  {
>  	char buf[18], *z = &buf[17];
>  
> @@ -135,7 +135,6 @@ static void print_hex_l(unsigned long num)
>  	hexdigit(num >> 20, &buf[12], &z);
>  	hexdigit(num >> 24, &buf[11], &z);
>  	hexdigit(num >> 28, &buf[10], &z);
> -
>  	hexdigit(num >> 32, &buf[9], &z);
>  	hexdigit(num >> 36, &buf[8], &z);
>  	hexdigit(num >> 40, &buf[7], &z);
> 




More information about the CRIU mailing list