[CRIU] [PATCH 05/23] include/restorer.h: use the alias UserRegsEntry for UserX86RegsEntry

Pavel Emelyanov xemul at parallels.com
Mon Jan 14 06:50:59 EST 2013


On 01/14/2013 03:46 PM, Alexander Kartashov wrote:
> On 01/14/2013 02:14 PM, Pavel Emelyanov wrote:
>> Can it be a typedef instead?
> 
> I think it does.
> 
> Nevertheless I have the following idea: what do you think about
> collecting all structures of this kind into single structure
> and choose appropriate structure while compiling. E.g.
> the structure UserRegsEntry would look like this:
> 
> struct UserRegsEntry {
>      UserX86RegsEntry x86;
>      UserArmRegsEntry arm;
> };
> 

Why struct? A anion? And why is typedef worse? I vote for typedef.


More information about the CRIU mailing list