[CRIU] [PATCH 0/5] log code update

Pavel Emelyanov xemul at parallels.com
Mon Jan 14 05:28:00 EST 2013


On 01/12/2013 05:06 PM, Cyrill Gorcunov wrote:
> The \n implicitly added to pr_perror message was bothering me
> all the time. So to be solid in coding style lets introduce
> pr_perr macro helper which will work just like pr_err, requiring
> new line in format message. In time all pr_perr should be moved
> to use pr_perr instead and finally pr_perror will be thrown out.
> 
> Cyrill Gorcunov (5):
>   log: Beautify log.h
>   log: Make pr_err_once to use pr_err
>   log: Add generic __print_on_level helper
>   log: Introduce print_on_level_perr helper
>   log: Introduce pr_perr macro
> 
>  include/log.h | 52 ++++++++++++++++++++++++++++++++++------------------
>  log.c         | 45 +++++++++++++++++++++++++++++++++++++++------
>  2 files changed, 73 insertions(+), 24 deletions(-)
> 


I applied patches 1-3, as for trimming \n-s from the end
of pr_perror calls -- I'd better keep in mind that I don't
have to put it _there_ rather than merging this awful kludge :(

Seriously, this intention just does not worth the pain.



More information about the CRIU mailing list