[CRIU] [PATCH 0/5] log code update

Andrew Vagin avagin at parallels.com
Sat Jan 12 13:30:08 EST 2013


On Sat, Jan 12, 2013 at 05:06:12PM +0400, Cyrill Gorcunov wrote:
> The \n implicitly added to pr_perror message was bothering me
> all the time. So to be solid in coding style lets introduce
> pr_perr macro helper which will work just like pr_err, requiring
> new line in format message. In time all pr_perr should be moved
> to use pr_perr instead and finally pr_perror will be thrown out.

I would like to add \n implicitly to pr_err, pr_info, pr_debug...
For each log functions, which adds something at the start of a line.

Where may we need to use pr_err without \n?

> 
> Cyrill Gorcunov (5):
>   log: Beautify log.h
>   log: Make pr_err_once to use pr_err
>   log: Add generic __print_on_level helper
>   log: Introduce print_on_level_perr helper
>   log: Introduce pr_perr macro
> 
>  include/log.h | 52 ++++++++++++++++++++++++++++++++++------------------
>  log.c         | 45 +++++++++++++++++++++++++++++++++++++++------
>  2 files changed, 73 insertions(+), 24 deletions(-)
> 
> -- 
> 1.8.0.1

> _______________________________________________
> CRIU mailing list
> CRIU at openvz.org
> http://lists.openvz.org/mailman/listinfo/criu



More information about the CRIU mailing list