[CRIU] [PATCH 06/19] pstree: Bind CoreEntry to pstree item

Cyrill Gorcunov gorcunov at openvz.org
Wed Feb 27 14:44:12 EST 2013


On Wed, Feb 27, 2013 at 05:15:57PM +0400, Pavel Emelyanov wrote:
> No.
> 
> 1. Don't make two copies of registers

Thread leader pstree item and parasite_ctl both keep same registers
_but_ in different format. For pstree entry they are encoded into
CoreEntry protobuf format and include FPU state. In turn for parasite_ctl
they are saved in native format which prctl understands and without
FPU state (since we know that we do not modify fpu state).

> 2. If you need to make N actions over a list of pstree-items,
>    do it in the
> 
>    for_each_pstree()
> 	action_1()
> 	action_2()
> 	...
> 	action_N()
> 
> manner, not the

Does attached one look better?


More information about the CRIU mailing list