[CRIU] [PATCH] ptrace: add ability to retrieve signals without removing from a queue (v2)
Pavel Emelyanov
xemul at parallels.com
Mon Feb 25 05:13:43 EST 2013
> + for (i = 0; i < arg.nr; i++) {
> + off = arg.off + i;
> +
> + spin_lock_irq(&child->sighand->siglock);
> + list_for_each_entry(q, &pending->list, list) {
> + if (!off--) {
> + copy_siginfo(&info, &q->info);
> + break;
> + }
> + }
> + spin_unlock_irq(&child->sighand->siglock);
What's the point of arg.nr if you for every single siginfo drop the lock
and perform linear search anyway?
Thanks,
Pavel
More information about the CRIU
mailing list