[CRIU] [PATCH 3/5] protobuf: Add include/protobuf symlink

Cyrill Gorcunov gorcunov at openvz.org
Tue Feb 5 17:29:04 EST 2013


On Wed, Feb 06, 2013 at 02:21:51AM +0400, Pavel Emelyanov wrote:
> On 02/06/2013 12:04 AM, Cyrill Gorcunov wrote:
> > 
> > This will allow us to lookup for protobuf
> > headers by relative
> > 
> > 	#include "protobuf/some-file.h"
> > 
> > instead of jumping over directory as we do now
> > 
> > 	#include "../protobuf/some-file.h"
> 
> Why not feed the proper -I option to gcc instead?

We can do that, but it makes code less readable I think,
because we will have to delete ".." part anyway and add
-Icrtools/ as path for lookup which I find _very_ strange.

In turn, when we use include/protobuf symlink, the standart
"crtools/include" directory is involved into lookup which I
found pretty convenient and just right.

Finlly my idea is to left only two directories for headers

	crtools/include
	crtools/arch/ARCH/include/asm

and that's all. But it requires some more cleanup works
since at moment all things are too interweaved.


More information about the CRIU mailing list