[CRIU] [PATCH 00/12] make rework, v1

Pavel Emelyanov xemul at parallels.com
Tue Feb 5 17:20:01 EST 2013


Stas, plz, review this set.

On 02/05/2013 01:34 PM, Cyrill Gorcunov wrote:
> Hi guys, I'm pleased to announce reworked make proccedure. The main reason
> for it was to provide some common make infrastructure which we use for all
> crtools code.
> 
> An idea is simple though. We add scripts/Makefile.build where all rules
> we might need are generated on the fly. The caller, ie main Makefile file
> calls for subbuild procedure as
> 
> 	make -f scripts/Makefile.build obj=<directory> all
> 
> the scripts/Makefile.build in turn includes <directory>/Makefile
> and generates make recipes.
> 
> As a positive side effect of this we now
> 
>  - generete deps on pie target
>  - can build precise targets as
> 
> 	make protobuf/core.o
> 
> Please review. Any comments are appreciated.
> 
> Cyrill Gorcunov (12):
>   make: Drop unneeded HEXDUMP
>   make: Use -f option for rm
>   make: Generate crtools version from Makefile definition
>   Add include/version.h to .gitignore
>   make: pie -- Add util-net.c symlink
>   make: Add scripts/Makefile.rules
>   make: Use scripts/Makefile.rules
>   make: Add scripts/Make.build helper
>   make: pie -- Switch to new build scheme
>   make: Add scripts/Makefile.protobuf
>   make: protobuf -- Switch to new build scheme
>   make: arch -- Switch to new build scheme
> 
>  .gitignore                  |   1 +
>  Makefile                    |  64 +++++++++---------
>  arch/arm/Makefile           |  71 +++++++++++---------
>  arch/x86/Makefile           |  79 ++++++++++++----------
>  arch/x86/syscalls-x86-64.sh |  11 +--
>  crtools.c                   |   3 +-
>  include/crtools.h           |   3 -
>  pie/Makefile                |  87 ++++++++++++------------
>  pie/gen-offsets.sh          |   7 +-
>  pie/util-net.c              |   1 +
>  protobuf/Makefile           | 159 +++++++++++++++++++++-----------------------
>  scripts/Makefile.build      |  79 ++++++++++++++++++++++
>  scripts/Makefile.rules      |  59 ++++++++++++++++
>  scripts/Makefile.version    |  23 +++++++
>  14 files changed, 407 insertions(+), 240 deletions(-)
>  create mode 120000 pie/util-net.c
>  create mode 100644 scripts/Makefile.build
>  create mode 100644 scripts/Makefile.rules
>  create mode 100644 scripts/Makefile.version
> 




More information about the CRIU mailing list