[CRIU] [PATCH 05/10] plugin: allow to use logging function in plugins

[Andrey Vagin]

Signed-off-by: Andrey Vagin <avagin at openvz.org>
---
 include/criu-log.h   | 70 ++++++++++++++++++++++++++++++++++++++++++++++++++++
 include/log-levels.h | 12 ---------
 include/log.h        | 43 ++------------------------------
 pie/log-simple.c     |  1 -
 4 files changed, 72 insertions(+), 54 deletions(-)
 create mode 100644 include/criu-log.h
 delete mode 100644 include/log-levels.h

diff --git a/include/criu-log.h b/include/criu-log.h
new file mode 100644
index 0000000..bc278c9
--- /dev/null
+++ b/include/criu-log.h
@@ -0,0 +1,70 @@
+/*
+    This file defines types and macros for CRIU plugins.
+    Copyright (C) 2013 Parallels, Inc
+
+    This program is free software; you can redistribute it and/or modify
+    it under the terms of the GNU General Public License as published by
+    the Free Software Foundation; either version 2 of the License, or
+    (at your option) any later version.
+
+    This program is distributed in the hope that it will be useful,
+    but WITHOUT ANY WARRANTY; without even the implied warranty of
+    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+    GNU General Public License for more details.
+
+    You should have received a copy of the GNU General Public License
+    along with this program; if not, write to the Free Software
+    Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
+ */
+
+#ifndef __CRIU_LOG_H__
+#define __CRIU_LOG_H__
+
+#define LOG_MSG		(0) /* Print message regardless of log level */
+#define LOG_ERROR	(1) /* Errors only, when we're in trouble */
+#define LOG_WARN	(2) /* Warnings, dazen and confused but trying to continue */
+#define LOG_INFO	(3) /* Informative, everything is fine */
+#define LOG_DEBUG	(4) /* Debug only */
+
+extern void print_on_level(unsigned int loglevel, const char *format, ...)
+	__attribute__ ((__format__ (__printf__, 2, 3)));
+
+#ifndef LOG_PREFIX
+# define LOG_PREFIX
+#endif
+
+#define pr_msg(fmt, ...)							\
+	print_on_level(LOG_MSG,							\
+		       fmt, ##__VA_ARGS__)
+
+#define pr_info(fmt, ...)							\
+	print_on_level(LOG_INFO,						\
+		       LOG_PREFIX fmt, ##__VA_ARGS__)
+
+#define pr_err(fmt, ...)							\
+	print_on_level(LOG_ERROR,						\
+		       "Error (%s:%d): " LOG_PREFIX fmt,			\
+		       __FILE__, __LINE__, ##__VA_ARGS__)
+
+#define pr_err_once(fmt, ...)							\
+	do {									\
+		static bool __printed;						\
+		if (!__printed) {						\
+			pr_err(fmt, ##__VA_ARGS__);				\
+			__printed = 1;						\
+		}								\
+	} while (0)
+
+#define pr_warn(fmt, ...)							\
+	print_on_level(LOG_WARN,						\
+		       "Warn  (%s:%d): " LOG_PREFIX fmt,			\
+		       __FILE__, __LINE__, ##__VA_ARGS__)
+
+#define pr_debug(fmt, ...)							\
+	print_on_level(LOG_DEBUG,						\
+		       LOG_PREFIX fmt, ##__VA_ARGS__)
+
+#define pr_perror(fmt, ...)							\
+	pr_err(fmt ": %m\n", ##__VA_ARGS__)
+
+#endif /* __CR_LOG_LEVELS_H__ */
diff --git a/include/log-levels.h b/include/log-levels.h
deleted file mode 100644
index 3e6753f..0000000
--- a/include/log-levels.h
+++ /dev/null
@@ -1,12 +0,0 @@
-#ifndef __CR_LOG_LEVELS_H__
-#define __CR_LOG_LEVELS_H__
-
-#define LOG_MSG		(0) /* Print message regardless of log level */
-#define LOG_ERROR	(1) /* Errors only, when we're in trouble */
-#define LOG_WARN	(2) /* Warnings, dazen and confused but trying to continue */
-#define LOG_INFO	(3) /* Informative, everything is fine */
-#define LOG_DEBUG	(4) /* Debug only */
-
-#define DEFAULT_LOGLEVEL	LOG_WARN
-
-#endif /* __CR_LOG_LEVELS_H__ */
diff --git a/include/log.h b/include/log.h
index 1060254..9948098 100644
--- a/include/log.h
+++ b/include/log.h
@@ -1,7 +1,7 @@
 #ifndef __CR_LOG_H__
 #define __CR_LOG_H__
 
-#include "log-levels.h"
+#include "criu-log.h"
 
 extern int log_init(const char *output);
 extern void log_fini(void);
@@ -16,48 +16,9 @@ extern unsigned int log_get_loglevel(void);
 
 extern int vprint_num(char *buf, int blen, int num, char **ps);
 
-extern void print_on_level(unsigned int loglevel, const char *format, ...)
-	__attribute__ ((__format__ (__printf__, 2, 3)));
-
 extern int write_pidfile(int pid);
 
-#ifndef LOG_PREFIX
-# define LOG_PREFIX
-#endif
-
-#define pr_msg(fmt, ...)							\
-	print_on_level(LOG_MSG,							\
-		       fmt, ##__VA_ARGS__)
-
-#define pr_info(fmt, ...)							\
-	print_on_level(LOG_INFO,						\
-		       LOG_PREFIX fmt, ##__VA_ARGS__)
-
-#define pr_err(fmt, ...)							\
-	print_on_level(LOG_ERROR,						\
-		       "Error (%s:%d): " LOG_PREFIX fmt,			\
-		       __FILE__, __LINE__, ##__VA_ARGS__)
-
-#define pr_err_once(fmt, ...)							\
-	do {									\
-		static bool __printed;						\
-		if (!__printed) {						\
-			pr_err(fmt, ##__VA_ARGS__);				\
-			__printed = 1;						\
-		}								\
-	} while (0)
-
-#define pr_warn(fmt, ...)							\
-	print_on_level(LOG_WARN,						\
-		       "Warn  (%s:%d): " LOG_PREFIX fmt,			\
-		       __FILE__, __LINE__, ##__VA_ARGS__)
-
-#define pr_debug(fmt, ...)							\
-	print_on_level(LOG_DEBUG,						\
-		       LOG_PREFIX fmt, ##__VA_ARGS__)
-
-#define pr_perror(fmt, ...)							\
-	pr_err(fmt ": %m\n", ##__VA_ARGS__)
+#define DEFAULT_LOGLEVEL	LOG_WARN
 
 #define DEFAULT_LOG_FILENAME "criu.log"
 
diff --git a/pie/log-simple.c b/pie/log-simple.c
index 701740d..6a9c6ae 100644
--- a/pie/log-simple.c
+++ b/pie/log-simple.c
@@ -4,7 +4,6 @@
 
 #include "syscall.h"
 #include "log.h"
-#include "log-levels.h"
 
 #define LOG_SIMPLE_CHUNK	72
 
-- 
1.8.3.1