[CRIU] [PATCH 01/12]v2 page-read: add print error in case of bad or corrupted image

Pavel Emelyanov xemul at parallels.com
Mon Dec 16 06:02:23 PST 2013


On 12/16/2013 02:55 PM, Tikhomirov Pavel wrote:
> 1. add it instead of BUG_ON
> we should print error if flag isn't assigned
> 2. correct use of read_pagemap_page_from_parent, provide no flag
> 
> Signed-off-by: Tikhomirov Pavel <snorcht at gmail.com>
> ---
>  page-read.c |   11 ++++++++---
>  1 file changed, 8 insertions(+), 3 deletions(-)
> 
> diff --git a/page-read.c b/page-read.c
> index 83820fa..c416462 100644
> --- a/page-read.c
> +++ b/page-read.c
> @@ -83,7 +83,7 @@ static void skip_pagemap_pages(struct page_read *pr, unsigned long len)
>  	pr->cvaddr += len;
>  }
>  
> -static int read_pagemap_page_from_parent(struct page_read *pr, unsigned long vaddr, void *buf)
> +static int read_pagemap_page_from_parent(struct page_read *pr, unsigned long vaddr, void *buf, int flags)

s/int flags/bool warn/

>  {
>  	int ret;
>  	struct iovec iov;


More information about the CRIU mailing list