[CRIU] [PATCH 3/8] unix: add ability to set callbacks for external sockets (v2)

Andrew Vagin avagin at parallels.com
Thu Dec 12 06:17:10 PST 2013


On Thu, Dec 12, 2013 at 12:43:07AM +0400, Pavel Emelyanov wrote:
> On 12/12/2013 12:11 AM, Andrew Vagin wrote:
> > On Wed, Dec 11, 2013 at 06:27:18PM +0400, Pavel Emelyanov wrote:
> >>> @@ -814,6 +840,28 @@ static int open_unixsk_standalone(struct unix_sk_info *ui)
> >>>  		close(sks[1]);
> >>>  		sk = sks[0];
> >>>  	} else {
> >>> +		sk = cr_plugin_restore_unix_sk(ui->ue->ino);
> >>> +		if (sk >= 0) {
> >>> +			ui->ue->uflags |= USK_CALLBACK;
> >>
> >> This is the _only_ place where the USK_CALLBACK flag is used. You've probably
> >> missed putting it on dump.
> > 
> > I forgot to remove it from here. Thanks.
> 
> What do you mean "remove"? Sockets with callbacks must be marked with
> some bit.

We can't mark a socket, we can makr a fake peer entry.

We was talking about that with you and decided, that sockets, which are
connected to one peer, can be handled by different callbacks and some of
them can be dumped as external.


More information about the CRIU mailing list