[CRIU] [PATCH 1/2]v2 page-read: add print error in case of bad or corrupted image

Pavel Emelyanov xemul at parallels.com
Mon Dec 2 03:29:39 PST 2013


On 12/02/2013 02:53 PM, Tikhomirov Pavel wrote:
> 1. add it instead of BUG_ON
> we should print error if flag isn't assigned
> 2. correct use of read_pagemap_page_from_parent, provide no flag
> 
> Signed-off-by: Tikhomirov Pavel <snorcht at gmail.com>
> ---
>  include/page-read.h |    2 ++
>  page-read.c         |   11 ++++++++---
>  2 files changed, 10 insertions(+), 3 deletions(-)
> 
> diff --git a/include/page-read.h b/include/page-read.h
> index b19ea69..5ad6325 100644
> --- a/include/page-read.h
> +++ b/include/page-read.h
> @@ -66,4 +66,6 @@ struct page_read {
>  };
>  
>  int open_page_read(int pid, struct page_read *);
> +
> +#define DO_NOT_PRINT_ERROR 1

There's no need in the whole flag in global header. Just add
bool argument. And do this as a part of the compacting patchset.


More information about the CRIU mailing list