[CRIU] [PATCH 3/4] unix: add ability to set callbacks for external sockets

[Cyrill Gorcunov]

On Mon, Dec 02, 2013 at 08:47:11AM +0400, Andrew Vagin wrote:
> 
> > 
> > Data exchange with libraries
> > ============================
> > 
> > I think we might pass protobuf objects to libraries because it's extendable
> > so if one day you need to pass more insformation to library you simply update
> > protobuf file.
> 
> Pavel has suggested to pass structure with size. It's extendable too.

Not that convenient as protobuf.

> > 	optional criu_plugin_hook	plugin_hook	= 14;
> 
> diff --git a/protobuf/sk-unix.proto b/protobuf/sk-unix.proto
> index bbe2588..9f87baa 100644
> --- a/protobuf/sk-unix.proto
> +++ b/protobuf/sk-unix.proto
> @@ -39,4 +39,5 @@ message unix_sk_entry {
>         optional sk_shutdown            shutdown        = 12;
>  
>         optional file_perms_entry       file_perms      = 13;
> +       optional bool                   need_callback   = 14;
>  }
> 
> I don't understand why we need dump and restore arguments.

I thought this will be more convenient, but sure one arg is fine
from tech. point of view (I didn't like unbalanced dump/restore
entry). Anyway, it's up to you.

> 
> Thank you for the comments.
> 

With my pleasre ;)