[CRIU] [PATCH 2/3] pie: don't use pr_perror in pie code

Andrey Wagin avagin at gmail.com
Fri Aug 30 08:41:00 EDT 2013


2013/8/30 Cyrill Gorcunov <gorcunov at gmail.com>:
> On Fri, Aug 30, 2013 at 04:29:10PM +0400, Andrew Vagin wrote:
>> Pavel, could you commit this patch?
>>
>
> Does it still applies after util-fd/util splitup?

[root at avagin-fc19-cr crtools]# git log pie/util.c

commit 786d374c549a79f63c2079635ead4e52a26dbc61
Author: Andrey Vagin <avagin at openvz.org>
Date:   Thu Aug 29 11:20:54 2013 +0400

    pie: don't use pr_perror in pie code

    pr_perror uses errno, which is set by glibc wrappers.
    In pi return codes of syscalls should be printed

commit c75c92db1d0a43f153aee229e0d6a69f3035f824
Author: Cyrill Gorcunov <gorcunov at openvz.org>
Date:   Wed Aug 28 23:57:46 2013 +0400

    pie: Move send_fds/recv_fds helpers into separate pie/util-fd.c

    We will need to reuse this code in criu library, where libc calls
    are present thus we will be compiling it in shared mode.

    Because internal syscalls library won't be needed we wrap them
    with __sys macro which would hide the details of invocation depending
    on CR_NOGLIBC preprocessor variable passed from command line.

    Original-patch-by: Ruslan Kuprieiev <kupruser at gmail.com>
    Signed-off-by: Cyrill Gorcunov <gorcunov at openvz.org>
    Signed-off-by: Pavel Emelyanov <xemul at parallels.com>


More information about the CRIU mailing list