[CRIU] [PATCH 08/10] mount: prevent dumping mounts, if they can't be restored (v2)

[Andrew Vagin]

On Thu, Aug 29, 2013 at 04:39:44PM +0400, Pavel Emelyanov wrote:
> > @@ -1115,6 +1183,9 @@ static int populate_mnt_ns(int ns_pid)
> >  	if (!pms)
> >  		return -1;
> >  
> > +	if (validate_mounts(pms))
> 
> Why not put this call into collect_shared()?

validate_mounts checks that the tree can be dumped and restored.
collect_shared() searches dependencies between mounts and don't know
nothing about dumping and restoring.

> 
> > +		return -1;
> > +
> >  	return mnt_tree_for_each(pms, do_mount_one);
> >  err:
> >  	while (pms) {
> > 
> 
>