[CRIU] [PATCH 2/3] pie: Move send_fds/recv_fds helpers into separate pie/util-net.c

Cyrill Gorcunov gorcunov at gmail.com
Wed Aug 28 11:14:23 EDT 2013


On Wed, Aug 28, 2013 at 07:08:17PM +0400, Pavel Emelyanov wrote:
> On 08/28/2013 06:17 PM, Cyrill Gorcunov wrote:
> > 
> > We will need to reuse this code in criu library, where libc calls
> > are present thus we will be compiling it in shared mode.
> > 
> > Because internal syscalls library won't be needed we wrap them
> > with __sys macro which would hide the details of invocation depending
> > on CR_NOGLIBC preprocessor variable passed from command line.
> > 
> > Original-patch-by: Ruslan Kuprieiev <kupruser at gmail.com>
> > Signed-off-by: Cyrill Gorcunov <gorcunov at openvz.org>
> > ---
> >  Makefile       |   1 +
> >  pie/Makefile   |   1 +
> >  pie/util-net.c | 157 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> 
> If we're going this way, let's call this util-fd.c, OK?
> BTW, maybe it's time to have util/ directory with lots of small
> files, each one get linked into appropriate place?

Sure, it's not a problem. I agree some separate directory might help here.
Will do.


More information about the CRIU mailing list