[CRIU] [PATCH 4/4] Makefile.inc: add conditional --no-print-directory

Kir Kolyshkin kir at parallels.com
Fri Apr 26 17:15:42 EDT 2013


On 04/24/2013 04:45 AM, Andrey Vagin wrote:
> On Wed, Apr 24, 2013 at 01:34:02PM +0400, Pavel Emelyanov wrote:
>> On 04/24/2013 02:12 AM, Kir Kolyshkin wrote:
>>> Let's add --no-print-directory to MAKEFLAGS only in case of silent
>>> build.
>>>
>>> Before:
>>>
>>> [kir at kirpad crtools]$ make
>>> make[1]: Entering directory `/vz/kir/git/crtools'
>>> make[1]: Leaving directory `/vz/kir/git/crtools'
>>> make[1]: Entering directory `/vz/kir/git/crtools'
>>> make[1]: Leaving directory `/vz/kir/git/crtools'
>>> make[1]: Entering directory `/vz/kir/git/crtools'
>>> make[1]: Leaving directory `/vz/kir/git/crtools'
>>> make[1]: Entering directory `/vz/kir/git/crtools'
>>> make[2]: Entering directory `/vz/kir/git/crtools'
>>> make[2]: Leaving directory `/vz/kir/git/crtools'
>>> make[2]: Entering directory `/vz/kir/git/crtools'
>>> make[2]: `arch/x86/syscalls.built-in.o' is up to date.
>>> make[2]: Leaving directory `/vz/kir/git/crtools'
>>> make[2]: Entering directory `/vz/kir/git/crtools'
>>> make[2]: `arch/x86/crtools.built-in.o' is up to date.
>>> make[2]: Leaving directory `/vz/kir/git/crtools'
>>> make[2]: Entering directory `/vz/kir/git/crtools'
>>> make[2]: Leaving directory `/vz/kir/git/crtools'
>>> make[2]: Entering directory `/vz/kir/git/crtools'
>>> make[2]: `pie/util-net.o' is up to date.
>>> make[2]: Leaving directory `/vz/kir/git/crtools'
>>> make[2]: Entering directory `/vz/kir/git/crtools'
>>> make[2]: Leaving directory `/vz/kir/git/crtools'
>>> make[2]: Entering directory `/vz/kir/git/crtools'
>>> make[2]: `built-in.o' is up to date.
>>> make[2]: Leaving directory `/vz/kir/git/crtools'
>>> make[1]: Leaving directory `/vz/kir/git/crtools'
>>>
>>> After:
>>>
>>> [kir at kirpad crtools]$ make
>>> make[2]: `arch/x86/syscalls.built-in.o' is up to date.
>>> make[2]: `arch/x86/crtools.built-in.o' is up to date.
>>> make[2]: `pie/util-net.o' is up to date.
>>> make[2]: `built-in.o' is up to date.
>> Andrey will hate you for dropping directories, as it makes vim+make work poorly.
>> Andrey?
> Yes, Andrey will hate everyone who will try to break his workflow. I'm
> sorry, but it's out of my force to change anything.

This is why I made this a separate patch.

So can someone just apply the first three please?

>
> The best regards,
> Andrey's angel.
>
> commit bf598fa28cde6afed5aa3bcb6c0ac138506f9852
> Author: Andrey Vagin <avagin at openvz.org>
> Date:   Mon Dec 3 14:53:17 2012 +0400
>
> make: fix navigation in vim
>
> If you have an error in parasite.c and execute make from vim,
> without this patch vim opens a new file parasite.c in a root directory.
>
> With this patch vim opens pie/parasite.c.
>
> Signed-off-by: Andrey Vagin <avagin at openvz.org>
> Signed-off-by: Pavel Emelyanov <xemul at parallels.com>
>
>
>>> Cc: Cyrill Gorcunov <gorcunov at openvz.org>
>>> Signed-off-by: Kir Kolyshkin <kir at openvz.org>
>>> ---
>>>   Makefile.inc | 1 +
>>>   1 file changed, 1 insertion(+)
>>>
>>> diff --git a/Makefile.inc b/Makefile.inc
>>> index f11cdcc..ee0b62c 100644
>>> --- a/Makefile.inc
>>> +++ b/Makefile.inc
>>> @@ -3,6 +3,7 @@
>>>   ifeq ($(strip $(V)),)
>>>   	E = @echo
>>>   	Q = @
>>> +	MAKEFLAGS += --no-print-directory
>>>   else
>>>   	E = @\#
>>>   	Q =
>>>
>>



More information about the CRIU mailing list