[CRIU] [PATCH] session03: change CLONE_STACK_SIZE from PAGE_SIZE to 4096

Andrew Vagin avagin at parallels.com
Thu Apr 25 03:39:38 EDT 2013


Acked-by: Andrew Vagin <avagin at parallels.com>

On Thu, Apr 25, 2013 at 01:42:30PM +0800, Libo Chen wrote:
> 
> Update to patch "check: Introduce --ms option" (commit: 379abca968850d0fb66f42115178b040b3a1f5bb)
> 
> I find this error in my box:
> cc -g -O2 -Wall -Werror -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0 -iquote ../../lib/arch/x86/include -I../../lib   session03.c ../../lib/libzdtmtst.a   -o session03
> session03.c:112:7: error: variably modified ‘stack’ at file scope
> 
> The reason is :
> "#define CLONE_STACK_SIZE PAGE_SIZE" is conflict with  "#define PAGE_SIZE  (sysconf(_SC_PAGESIZE))" defined in <sys/user.h>.
> 
> I think CLONE_STACK_SIZE should be seted  4096 as session02.c.
> 
> If this patch is appropriate, please let me know.
> 
> Signed-off-by: Libo Chen <libo.chen at huawei.com>
> Signed-off-by: Qiang Huang <h.huangqiang at huawei.com>
> ---
>  test/zdtm/live/static/session03.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/test/zdtm/live/static/session03.c b/test/zdtm/live/static/session03.c
> index 6cb8e4d..0c761b3 100644
> --- a/test/zdtm/live/static/session03.c
> +++ b/test/zdtm/live/static/session03.c
> @@ -106,7 +106,7 @@ static void mainloop()
>  		handle_command();
>  }
> 
> -#define CLONE_STACK_SIZE	PAGE_SIZE
> +#define CLONE_STACK_SIZE	4096
>  /* All arguments should be above stack, because it grows down */
>  struct clone_args {
>  	char stack[CLONE_STACK_SIZE];
> -- 
> 1.7.10.4
> 
> 
> 
> _______________________________________________
> Kernel.openeuler mailing list
> Kernel.openeuler at huawei.com
> http://rnd-openeuler.huawei.com/mailman/listinfo/kernel.openeuler
> 
> 
> 
> 
> 


More information about the CRIU mailing list