[CRIU] [PATCH] page-xfer: close sockets on errror paths

Pavel Emelyanov xemul at parallels.com
Fri Apr 12 12:56:28 EDT 2013


On 04/12/2013 08:53 PM, Cyrill Gorcunov wrote:
> On Fri, Apr 12, 2013 at 08:46:56PM +0400, Pavel Emelyanov wrote:
>> On 04/12/2013 04:14 PM, Andrey Vagin wrote:
>>> CID 996195 (#1 of 1): Resource leak (RESOURCE_LEAK)
>>> 10. leaked_handle: Handle variable ask going out of scope leaks the handle.
>>>
>>> CID 996196 (#3 of 3): Resource leak (RESOURCE_LEAK)
>>> 10. leaked_handle: Handle variable sk going out of scope leaks the handle.
>>
>> Can we teach this soft not to warn us about not closed files on paths,
>> that lead directly to program termination?
> 
> In general -- no, but we can mark every issue as "intended" thus coverity
> won't warn about it next time.
> .
> 


Let's do it, please. I'm becoming tired of patches with xfree-s and close-s
on mem and files, that are to be closed by exit(-1) in a moment.


More information about the CRIU mailing list