[CRIU] [PATCH 00/32] tools, cpt2 introduction, v1

[Pavel Emelyanov]

On 04/01/2013 02:43 PM, Cyrill Gorcunov wrote:
> On Mon, Apr 01, 2013 at 02:13:59PM +0400, Pavel Emelyanov wrote:
>> On 04/01/2013 02:05 PM, Cyrill Gorcunov wrote:
>>> On Mon, Apr 01, 2013 at 01:52:40PM +0400, Pavel Emelyanov wrote:
>>>>>  57 files changed, 8360 insertions(+), 3 deletions(-)
>>>>
>>>> I gave up on patch #9. How much of these 8.3K lines are just copy-n-paste
>>>> from original crtools/ code?
>>>
>>> this is abstract fdset engine which is not bound to anything else (i did
>>> think of moving this code to crtools and reuse it in cpt2).
>>>
>>> thus the things which look similar
>>>
>>>  - image engine
>>>  - protobuf
>>>  - fdset
>>
>> Please, use stuff from crtools/ next time. Presumably it's OK just to link
>> respective .o files into conversion binary.
> 
> Pavel, I can't. for example our templates for criu files do have links
> to "show" routines, which we don't have in cpt2. fdset code is suffering
> from same problem, crtools code is too hooked into the rest of crtools codebase.

This excuses the .c code reuse, but not constants and .h helpers.

> .
>