[CRIU] Re: [PATCH] zdtm: Mount devtmpfs and devpts in new root

[Cyrill Gorcunov]

On Fri, Sep 28, 2012 at 11:25:02PM +0400, Cyrill Gorcunov wrote:
> On Fri, Sep 28, 2012 at 11:06:03PM +0400, Andrew Vagin wrote:
> > On Mon, Sep 17, 2012 at 01:53:33PM +0400, Cyrill Gorcunov wrote:
> > > In case if we enter the new rootfs don't forget to
> > > maount devtmpfs and devpts, otherwise ttys can't
> > > be connected.
> > > 
> > > Signed-off-by: Cyrill Gorcunov <gorcunov at openvz.org>
> > > ---
> > >  test/zdtm/lib/ns.c |    9 +++++++++
> > >  1 files changed, 9 insertions(+), 0 deletions(-)
> > > 
> > > diff --git a/test/zdtm/lib/ns.c b/test/zdtm/lib/ns.c
> > > index 664715f..4a933cc 100644
> > > --- a/test/zdtm/lib/ns.c
> > > +++ b/test/zdtm/lib/ns.c
> > > @@ -107,6 +107,15 @@ done:
> > >  			fprintf(stderr, "mount(/proc) failed: %m\n");
> > >  			return -1;
> > >  		}
> > > +		if (mount("devtmpfs", "/dev", "devtmpfs", MS_MGC_VAL, NULL)) {
> > 
> > Why do we need devtmpfs?
> 
> Without it the /dev/pts fails to mount as
> 
>  | mount(/dev/pts) failed: No such file or directory
> 
> in result pty tests are failing inside ns.

As being discussed in IM, I'll update the patches.