[CRIU] [PATCH] restorer: Add "memory" constraint into asm statement

Cyrill Gorcunov gorcunov at openvz.org
Tue Sep 25 05:47:55 EDT 2012


On Tue, Sep 25, 2012 at 01:39:23PM +0400, Glauber Costa wrote:
> On 09/24/2012 07:23 PM, Cyrill Gorcunov wrote:
> > It seems otherwise older gcc compilers do treat this
> > statement as incomplete.
> > 
> > Signed-off-by: Cyrill Gorcunov <gorcunov at openvz.org>
> > ---
> >  restorer.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/restorer.c b/restorer.c
> > index d516bed..df95e00 100644
> > --- a/restorer.c
> > +++ b/restorer.c
> > @@ -705,6 +705,6 @@ core_restore_failed:
> >  		"jmp *%%rax				\n"
> >  		:
> >  		: "r"(ret)
> > -		: );
> > +		: "memory");
> >  	return ret;
> >  }
> > 
> You can just add "" if you don't want to actually clobber memory, IIRC.

Well, "memory" actually won't hurt here as well ;) The problem is that
the reporter has not replied me if such trick helped him build the
program. It seems some older gcc series do not like empty clobbering
fields.


More information about the CRIU mailing list