[CRIU] Re: [PATCH 2/3] tty: Mark living peers in tty_active_pairs bitmap

Cyrill Gorcunov gorcunov at openvz.org
Tue Sep 18 11:03:38 EDT 2012


On Tue, Sep 18, 2012 at 06:59:49PM +0400, Cyrill Gorcunov wrote:
> On Tue, Sep 18, 2012 at 06:55:36PM +0400, Pavel Emelyanov wrote:
> > > +	/*
> > > +	 * Now trace the paired/unpaired ttys. For example
> > > +	 * the task might have slave peer assigned but no
> > > +	 * master peer. Such "detached" master peers are
> > > +	 * not yet supported by our tool and better to
> > > +	 * inform a user about such situatio,
> > > +	 */
> > > +	if (!hangup || major == TTYAUX_MAJOR)
> > 
> > Can this _ever_ be false?
> 
> Sure -- you just need a slave peer which is alive (ie hangup == false).
> The setting bit on master peer is for correspondence between master/slave
> peers.

Oh, sorry misread your "false" question. But same answer -- if slave
peer is dead the hangup = true and we don't mark this peer, at verifucation
stage we're only concerned if there alive slave peer without master.


More information about the CRIU mailing list