[CRIU] Re: [PATCH 2/4] tty: Add checkpoint/restore for unix terminals v3

Cyrill Gorcunov gorcunov at openvz.org
Fri Sep 7 11:03:57 EDT 2012


On Fri, Sep 07, 2012 at 06:49:18PM +0400, Pavel Emelyanov wrote:
> On 09/07/2012 06:45 PM, Cyrill Gorcunov wrote:
> > On Fri, Sep 07, 2012 at 06:39:33PM +0400, Pavel Emelyanov wrote:
> >>
> >> You assign the n_c_cc = TERMIOS_NCC, thus you should check in on restore.
> > 
> > Ah, that. I'll do a fix on top. Thanks!
> > 
> >> OK, this patch looks sane. Where's the rest with control terminals?
> > 
> > I'm cooking control terminals now (this requires more efforts than I
> > expected because I redesigned it, now control terminals should have
> > more transparent scheme of restore). Once it's done i'll send them
> > out. If you wish you can merge these patches since our test cases
> > do work with them just fine.
> 
> No, I will wait for the control ptys. I don't understand the .proto file
> layout you chose, need to see the whole picture.

Sure. This is mostly because of control ttys. Maybe once you see the
rest of patches you could advice me how to simplify all things.

	Cyrill


More information about the CRIU mailing list