[CRIU] [PATCH] zdtm: More detailed report on unmounting problem

Cyrill Gorcunov gorcunov at openvz.org
Tue Oct 30 13:27:32 EDT 2012


It seems I've screwed the setup and mount points on
my testing machine thus mountpoint test become failing.

Nevertheless, better to report where exactly we've failed
for easier investigation.

With this patch I get

 | ./mountpoints --pidfile=mountpoints.pid --outfile=mountpoints.out
 | 20:26:07.398:  1745: umount(`/dev') failed: Device or resource busy
 | 20:26:07.398:  1745: umount(`/vz') failed: Device or resource busy
 | 20:26:07.399:  1745: umount(`/vz') failed: Device or resource busy
 | 20:26:07.399:  1745: umount(`/vz') failed: Device or resource busy
 | 20:26:07.399:  1745: umount(`/vz') failed: Device or resource busy
 | 20:26:07.399:  1745: FAIL: mountpoints.c:60: Can't umount all the filesystems (errno = 16)
 | 20:26:07.404:  1744: ERR: test.c:298: Test exited with unexpectedly with code 1
 |  (errno = 4)

Signed-off-by: Cyrill Gorcunov <gorcunov at openvz.org>
---
 test/zdtm/live/static/mountpoints.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/test/zdtm/live/static/mountpoints.c b/test/zdtm/live/static/mountpoints.c
index f1d35dd..0e295fd 100644
--- a/test/zdtm/live/static/mountpoints.c
+++ b/test/zdtm/live/static/mountpoints.c
@@ -42,7 +42,8 @@ again:
 		if (!strcmp(mp, "/proc"))
 			continue;
 
-		umount(mp);
+		if (umount(mp))
+			test_msg("umount(`%s') failed: %m\n", mp);
 		fs_cnt++;
 	}
 
-- 
1.7.7.6



More information about the CRIU mailing list