[CRIU] Re: [PATCH] tty: Rework tty_find_restoring_task

Cyrill Gorcunov gorcunov at openvz.org
Mon Oct 29 16:33:36 EDT 2012


On Tue, Oct 30, 2012 at 12:19:02AM +0400, Andrew Vagin wrote:
> On Mon, Oct 29, 2012 at 11:28:32PM +0400, Cyrill Gorcunov wrote:
> > It's being found that we fail to restore tasks which
> > are not session leaders but have controlling terminals.
> 
> It is not true. Sorry, I made this mess in our heads.
> 
> When a session leader exited all processes in a current group get SIGHUP
> and a former controlling terminal becomes a non-controlling terminal.
> 
> > 
> > This patch reworks tty_find_restoring_task logic and
> > fixes the problem.
> 
> [root at localhost crtools]# cat
> /root/crtools/test/zdtm/live/static/tty02.out
> 20:10:04.536:     4: SIGHUP is here
> 20:10:04.966:     4: FAIL: tty02.c:59: The tty is a controlling for someone (errno = 4)

Yup, thanks. I'm working on that and will resend patch.


More information about the CRIU mailing list