[CRIU] Re: [PATCH 3/4] memory: Add pasing of VmFlags

[Cyrill Gorcunov]

On Fri, Oct 26, 2012 at 12:17:39AM +0400, Pavel Emelyanov wrote:
> On 10/25/2012 05:20 PM, Cyrill Gorcunov wrote:
> > 
> > The kernel now supports providing VMA flags via smaps
> > interface so add pasting of them.
> > 
> > Signed-off-by: Cyrill Gorcunov <gorcunov at openvz.org>
> > ---
> >  proc_parse.c       |   58 ++++++++++++++++++++++++++++++++++++++++++++++++++++
> >  protobuf/vma.proto |    3 ++
> >  2 files changed, 61 insertions(+), 0 deletions(-)
> > 
> 
> 
> > +		if (_vmflag_match(tok, "gd"))
> > +			vma_area->vma.flags |= MAP_GROWSDOWN;
> Plz, fix the existing MAP_GROWSDOWN heuristics incrementally.

Sure, this is rather addiotional hint for us (I mean we're in
good shape now with and without this bit ;-)

> 
> > +		else if (_vmflag_match(tok, "lo"))
> > +			vma_area->vma.flags |= MAP_LOCKED;
> 
> Methinks that this flag should be put on VMAs late in restorer.
> Fix this incrementally.

OK