[CRIU] Re: [PATCH 13/14] tty: Drop sid/pgid test from verify_info

Pavel Emelyanov xemul at parallels.com
Mon Oct 15 12:14:26 EDT 2012


On 10/15/2012 08:11 PM, Cyrill Gorcunov wrote:
> On Mon, Oct 15, 2012 at 08:07:12PM +0400, Pavel Emelyanov wrote:
>> On 10/15/2012 06:54 PM, Cyrill Gorcunov wrote:
>>>
>>> Since we've started fetching sid/pgid from the
>>> dumpee context we're allowed to obtain sid/pgid
>>> on a slave peer. This is perfectly valid. So
>>> drop this test.
>>>
>>> Signed-off-by: Cyrill Gorcunov <gorcunov at openvz.org>
>>> ---
>>
>> This check still makes sense for non-sheel-jobs slaves, doesn't it?
> 
> Nope. This check had sense when we were fetching global sids but
> since we've started to use parasite -- we can obtain sids on slave
> peer if the dumpee is session leader. Thus no need to do this test.
> 


OK, I see. Then the same comment as for patch #14 makes sense -- you don't
make difference between "good unpaired" slaves and "corrupted paired" ones.


More information about the CRIU mailing list