[CRIU] Re: [PATCH 2/2] pstree: Rename @list member to @sibling

Cyrill Gorcunov gorcunov at openvz.org
Wed Oct 3 10:00:25 EDT 2012


On Wed, Oct 03, 2012 at 05:50:47PM +0400, Cyrill Gorcunov wrote:
> 
> To be close to the kernel naming.
> 
> Signed-off-by: Cyrill Gorcunov <gorcunov at openvz.org>

If this series looks good for you -- here is one more update on top.
-------------- next part --------------
>From d02f1c742ee120be24591421cfa1c424a1cee33d Mon Sep 17 00:00:00 2001
From: Cyrill Gorcunov <gorcunov at openvz.org>
Date: Wed, 3 Oct 2012 17:53:04 +0400
Subject: [PATCH] dump: No need to init root_item->sibling

It's already done in alloc_pstree_item() by
recently merged commit.

Signed-off-by: Cyrill Gorcunov <gorcunov at openvz.org>
---
 cr-dump.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/cr-dump.c b/cr-dump.c
index a03813c..1c7a1a2 100644
--- a/cr-dump.c
+++ b/cr-dump.c
@@ -1210,7 +1210,6 @@ static int collect_pstree(pid_t pid, const struct cr_options *opts)
 			return -1;
 
 		root_item->pid.real = pid;
-		INIT_LIST_HEAD(&root_item->sibling);
 
 		ret = collect_subtree(root_item);
 		if (ret == 0) {
-- 
1.7.7.6



More information about the CRIU mailing list