[CRIU] [PATCH] zdtm: Use SIGWINCH instead of SIGTRAP in pthread01

Cyrill Gorcunov gorcunov at openvz.org
Thu Nov 22 13:36:47 EST 2012


On Thu, Nov 22, 2012 at 10:29:22PM +0400, Andrew Vagin wrote:
> So this patch should be splitted on three;)
> * switch to the signal which just known to work
> * s/sigprocmask/pthread_sigmask/
> * showing the signals mask to  more readable format

Sure, I can split it once I finish with more urgent tasks.
(Still as to me I don't see much reson in oversplitting ;)

> > +	COLLECT(SIGPOLL); COLLECT(SIGPWR); COLLECT(SIGSYS); COLLECT(SIGUNUSED);
> > +#undef COLLECT
> 
> I don't like this code. For me a hex number is better for reading than a
> set of SIG*... We need to show only u64.

For me hex numbers are _just_ hexnumber, frankly I don't have ability
to decode 64bit field to symbolic names in mind. But if you insist
I can live with that ;-)

	Cyrill


More information about the CRIU mailing list