[CRIU] [PATCH v4 1/4] make: move syscalls files and build to separated directory

Pavel Emelyanov xemul at parallels.com
Tue Nov 20 09:12:11 EST 2012


On 11/20/2012 06:03 PM, Kinsbursky Stanislav wrote:
> 20.11.2012 17:55, Pavel Emelyanov пишет:
>> On 11/19/2012 07:35 PM, Kinsbursky Stanislav wrote:
>>> From: Stanislav Kinsbursky <skinsbursky at openvz.org>
>>>
>>> This patch set moves all syscalls data to $(ARCH) directory ("x86_64" in this
>>> particular case).
>> Why not arch/x86 ?
> 
> Did you mean "arch/x86_64"?

No arch/x86. Kernel people had two dirs for 32 and 64 bit Intel architectures,
but now they have one -- x86. Why should we make our layout differ?

> I thought, that this could make sense only when we will add at least one more arch.
> 
>>
>>> It does also some cleanup to generic Makefile.inc and syscalls-x86-64.sh.
>> I bet you know how to re-split this patch ;)
> 
> Re-split? O_o
> I know, how to split.

Good. Then go ahead and do it.

>>
>>> Signed-off-by: Stanislav Kinsbursky <skinsbursky at openvz.org>
>>> ---
>>>   Makefile                       |   15 ++++++++-------
>>>   Makefile.inc                   |   11 ++++++++---
>>>   Makefile.pie                   |   18 +++++++++---------
>>>   x86_64/Makefile                |   21 ++++++++++++++-------
>>>   x86_64/syscall-common-x86-64.S |    0
>>>   x86_64/syscalls-x86-64.sh      |   12 +++++-------
>>>   6 files changed, 44 insertions(+), 33 deletions(-)
>>>   rename Makefile.syscall => x86_64/Makefile (64%)
>>>   rename syscall-common-x86-64.S => x86_64/syscall-common-x86-64.S (100%)
>>>   rename syscalls-x86-64.sh => x86_64/syscalls-x86-64.sh (74%)
>>>   mode change 100644 => 100755
>>>
>>
> 
> 





More information about the CRIU mailing list