[CRIU] [PATCH v3 1/4] make: move syscalls files and build to separated directory

Pavel Emelyanov xemul at parallels.com
Sun Nov 11 04:33:44 EST 2012


On 11/09/2012 12:02 PM, Kinsbursky Stanislav wrote:
> From: Stanislav Kinsbursky <skinsbursky at openvz.org>
> 
> Signed-off-by: Stanislav Kinsbursky <skinsbursky at openvz.org>
> ---
>  Makefile                        |   13 ++++++++-----
>  Makefile.inc                    |    2 ++
>  Makefile.pie                    |   18 +++++++++---------
>  syscall/Makefile                |   21 +++++++++++++++------
>  syscall/syscall-common-x86-64.S |    2 +-
>  syscall/syscalls-x86-64.sh      |   14 ++++++++------
>  6 files changed, 43 insertions(+), 27 deletions(-)
>  rename Makefile.syscall => syscall/Makefile (68%)
>  rename syscall-common-x86-64.S => syscall/syscall-common-x86-64.S (86%)
>  rename syscalls-x86-64.sh => syscall/syscalls-x86-64.sh (74%)
> 


I can understand the beauty of pie in separate directory. But a whole new
directory just for syscall-common-x86_64 file doesn't look nice. All the
more so, when we start supporting another architectures we'll most likely
move this file again, this time to arch/ dir.


More information about the CRIU mailing list