[CRIU] Re: [PATCH cr 3/3] zdtm: remove extra code from file_fown

[Cyrill Gorcunov]

On Wed, May 30, 2012 at 03:22:36PM +0400, Pavel Emelyanov wrote:
> On 05/30/2012 02:35 PM, Cyrill Gorcunov wrote:
> > On Wed, May 30, 2012 at 12:44:16PM +0400, Pavel Emelyanov wrote:
> >> All applied.
> >>
> >> Cyrill, Andrey says that fowner testcase doesn't pass after this patch.
> >> Why and how can we fix it?
> > 
> > The attached patch should fix it.
> > 
> > 	Cyrill
> 
> What do we need the shmem for since we synchronize child and parent
> via pipes anyway?

Huh? I need some operations to be yielded after restore, and the checkpoint
signal to be delivered after some writes to pipes are done, so frankly
I don't get _how_ you can guarantee the order via nonblocking pipes
here. Or maybe I miss what you have in mind?

> 
> And using assert_xxx doing { ret = xxx if (ret) goto } is obfuscating.
> Plz, opencode these parts. 

OK (but there is no goto at all).

	Cyrill