[CRIU] Re: [PATCH 2/2] fifo: Add checkpoint/restore for fifos

[Cyrill Gorcunov]

On Wed, May 30, 2012 at 12:35:09PM +0400, Pavel Emelyanov wrote:
> 
> This one should call the pipe shower.
> 

OK

> > +static int fifo_open(struct file_desc *d)
> > +{
> > +	struct fifo_file_info *info;
> > +	int tmp;
> > +
> > +	info = container_of(d, struct fifo_file_info, d);
> > +
> > +	tmp = open(info->path, info->ffe.flags);
> 
> This will hang if the opener is not O_RDWR.

Thanks

> > +	fd = fdset_fd(glob_fdset, CR_FD_FIFO);
> > +	if (write_img(fd, &e))
> > +		return -1;
> > +	if (write_img_buf(fd, pathbuf, len))
> > +		return -1;
> 
> It should call the regfile dumping code, since it's the same.
> And it should call the pipe dumping code for fifo's contents.

Will update

	Cyrill